jReviews Support Forum

Alejandro,

Haven't upgraded to the new version yet, so it is possible you changed somethings, but I was wondering if you have it on the schedule to make jReviews XHTML valid?

I get errors from this:


I believe it is due to the option_class which isn't an attribute for select.

I also get errors for this:


Which is the id for a checkbox.  The brackets are causing the errors I think.

Is there any file I can change myself to get rid of these or is this something you have to change?   I can always output them myself, but it would be easier to maintain if I didn't have to.   Thanks.

Steve

I don't claim XHTML compliance, so this isn't a priority. Can you please tell me what is the importance to be compliant?

Having said that:

1) I fixed the issues you've pointed out and it will be out in the next release
2) Are those the only two things keeping the theme from being xhtml valid?

Well, I guess there are multiple reasons to be compliant

1)  It is a standard.  Standards are good for the industry in that they make it easier to create things and less of a hassle to maintain.

2)  Because it is a standard, I've found best rendering behavior across browsers by remaining standards Compliant.  The docTypes at the top of your XHTML file basically say, "This page is coded to certain standard" and when you SAY that, but don't do it in the page, it can lead to rendering problems (such as IE6 and IE7 quirks mode)

3)  Straddling the line of designer and developer, I see what the LACK of attention to Standards can do.  For instance IE6.  I wasted almost 4 hours again today tracking down an IE6 bug because they don't render pages in a standards compliant way.


Finally, regardless of whether you care about it or not, I DO care about it, and unfortunately there are some things I can't change on jReviews.  I completely understand that you have it set up the way you do, but - as far as I understand it - I wouldn't be able to rectify these issues (I would happily do it if I can though)

The only other thing I could find that generated errors besides the two I mentioned were the S2 tags


Thanks for considering this.

Steve

Thanks. All those points make a lot of sense. I never said I didn't care, only that it's not the priority. I think a couple of non-compliant errors you found, which don't appear on all pages, speaks volumes of what I've actually done to get there. It just isn't a selling point, yet.

I'll look into the nocache issue as well.

Sorry - I shouldn't have used "don't care."  I completely agree that you've done a ton of work to get there.  I would never take anything away from what you've done with jReviews.  Great product and even better support.  :)  Sorry again, and thanks for looking into it.

Steve