jReviews Support Forum

jReviews 2.x => General discussion => Topic started by: Alejandro on July 16, 2008, 11:26:59 PM



Title: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: Alejandro on July 16, 2008, 11:26:59 PM
I've added the build 14 fixes + a few more and packaged it into build 15. These are small incremental changes in a short amount of time so I am just increasing the build numbers. This is likely to be the last release for a few weeks while reports of any remaining bugs come in, so that a stable version can finally be released.

I'll be traveling for the next 3 weeks so I won't be doing any development during that time and will dedicate a few hours a day to standard, rather than customization, support questions.

Read here for the complete jReviews 2.x changelog (http://www.reviewsforjoomla.com/Documentation/jReviews/jReviews-2.0-Changelog/)


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: bunglehaze on July 22, 2008, 06:09:48 PM
Alejandro, nice to have an update as the previous version stopped me being able to edit articles within Joomla, one thing though - are there any plans to streamline and compress the files involved at all? I have the reviews module published on my frontpage which bumps up the loading times considerably.

As an example, the page size without the reviews module is 147626kb which is seriously increased to 219851 published. Obviously in the world of trying to decrease site loading as much as possible if this is something that can be done it would be very helpful.

cheers

leigh :D


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: Alejandro on July 22, 2008, 07:52:02 PM
I have already decreased the size of several of the libraries used by over 50%, which was a lot. Check what's creating the difference and maybe try disabling the ajax pagination in the module to see if that prevents xajax from loading on the home page. Other than that I'll try to compress css files later on, but I am not sure how much that's going to improve things overall.


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: bunglehaze on July 23, 2008, 10:29:20 PM
Hi Alejandro, the xajax still appears to be showing up on page loads despite turning off the ajax pagination. The main thing I can see that is causing the bulk of the size is from the module calling all the theme images/files etcwhen IMO it really does not need to do so. When you take into consideration the 16116 bytes of the main theme css file and the remaining other files (images etc) weigh in at 37102 bytes being able to configure the module more easily would make a huge difference - for instance in my case I do not need most of the theme css images to load, simply the stars and the editor rating icon, no doubt others would want to eye-candy theirs up a little so there is a flipside.

What would make more sense is a less centralised theme so that in the module template an individual css can be created based on the individual requirement of the module in question, removing 53kb+ from loading on a frontpage could make the difference between being able to use Jreviews to its full potential or using a stripped down version of what was planned.

I must say though, I have huge respect for the work you have put in to this component and I love it! I would like to see it keep improving though so I hope these suggestions are of some use.

cheers

leigh :D


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: Alejandro on July 23, 2008, 11:08:27 PM
Leigh, you can easily see in the module theme file where the css files are being loaded. I did it that way so it would be easy for sophisticated users as yourself to take control ;)

You simply need to remove 'theme' from the array below and copy the classes you need to the module-specific css file.

Code:
$Html->css(array('theme','module_reviews','paginator'),$inline);

Easy, no?


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: bunglehaze on July 24, 2008, 08:30:52 AM
Quote
Easy no?

:D I will let you know :D

Cheers Alejandro, I thought I must have been missing something.

leigh :D


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: bunglehaze on July 24, 2008, 08:43:54 AM
excellent stuff... Now all I need to do is stop the xajax.js from loading on the frontpage and I am fully streamlined.

cheers

leigh :D


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: Alejandro on July 24, 2008, 07:28:39 PM
When you upgraded to build 15, did you also replace the module files in the /modules folder for both listings and reviews? I made a change to prevent xajax from loading if ajax pagination is disabled. When you open the mod_jreviews_listings/reviews.php files you should find something like this:

Code:
$Dispatcher = new jreviewsDispatcher((bool)$moduleParams['module']['ajax_nav']);
echo $Dispatcher->dispatch($moduleParams);

The boolean parameter for the jreviewsDispatcher class determines whether xajax is loaded or not.


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: bunglehaze on July 25, 2008, 08:45:33 PM
Hi Alejandro - yes I did a full upgrade ie. removed the entire component and module list and added the whole new package then reconfigured which I thought would be the safest bet to do on a production site.  The xajax is still loading though! I wonder if it might be something to do with the Yootheme template I am using?

cheers

leigh :D


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: Alejandro on July 26, 2008, 09:51:49 AM
Have you checked the module's php files to see if they contain the code as shown above?

You can try hard coding the false parameter to see if that helps:

Code:
$Dispatcher = new jreviewsDispatcher(false);

It might be also that xajax is loaded for the front page. You can try disabling jReviews from the frontpage in the jReviews Comments Plugin parameters.


Title: Re: Discuss the jReviews 2.0.4 RC3 Build 15 release annoucement
Post by: bunglehaze on July 26, 2008, 08:25:20 PM
I will have a look at hard coding Alejandro, I have turned off the loading of xajax in the frontpage setting in the plugin already - before I upgraded to .015 it seemed to have worked but now it pops up on all my loading tests.

regards

leigh :D