jReviews Support Forum

jReviews 1.x => jReviews 1.2.09 => Topic started by: Smylo on February 09, 2008, 08:40:49 AM



Title: double breaks after upgrade to 1.2.0.9
Post by: Smylo on February 09, 2008, 08:40:49 AM
Dear all,

after upgrading to the newest version of jReviews i have double breaks at any content item that was created with jReviews!

for example...

in the editor the html code looks like that:
text text text text <br />
text text text text <br />
<ul>
<li> text </li>
<li> text </li>
</ul>

and at the frontend it looks now like this:
text text text text <br /><br />
text text text text <br /><br />
<ul>
<li> text </li><br />
<li> text </li><br />
</ul>
<br />

it's very strange and i have don't know whats wrong. The problems only appears in jReviews content item..., in static content it looks like before the update - so there is no problem.

Thanks in advance
Smylo


Title: Re: double breaks after upgrade to 1.2.0.9
Post by: Alejandro on February 09, 2008, 09:25:19 AM
This is due to a change in jreviews.plugin.php:

Code:
$jreviewcontent['introtext'] = nl2br($row->introtext);
$jreviewcontent['fulltext'] = nl2br($row->fulltext);
You can remove the nl2br functions:

Code:
$jreviewcontent['introtext'] = $row->introtext;
$jreviewcontent['fulltext'] = $row->fulltext;

This was added because for users that are not using a wysiwyg editor the new lines where being ignored. I am not sure how to solve this yet, but for now this is what you need to do.


Title: Re: double breaks after upgrade to 1.2.0.9
Post by: Smylo on February 09, 2008, 07:00:50 PM
Thanks for your help -> it works perfectly!!!


Title: Re: double breaks after upgrade to 1.2.0.9
Post by: Undead on February 13, 2008, 06:14:47 PM
As a trial user, can i have a corrected version of jreviews.plugin.php or is there any inconveinence if I overwrite it with an old Zend-coded one?


Title: Re: double breaks after upgrade to 1.2.0.9
Post by: Alejandro on February 13, 2008, 07:42:02 PM
No, this file contains a license check in the trial to render it useless when the trial expires. You can try the older file, but then you probably will not be able to test the favorites functionality.

To overcome this for now, you can disable the wysiwyg editor or enable it if it's disabled. I can't think straight right now!


Title: Re: double breaks after upgrade to 1.2.0.9
Post by: Undead on February 13, 2008, 08:51:56 PM
I've disabled the WYSIWYG editor and it worked! Thank you Alejandro. You're really great!


Title: Re: double breaks after upgrade to 1.2.0.9
Post by: Tony Lindskog on April 16, 2008, 04:03:52 PM
Great fix Alejandro - this explains why older articles worked that was using the regular Joomla wysiwyg editor and why the new ones written by XHTMLsuite got double lined.

Thanks again,

--Tone