Changing Button Class Breaks Proximity Search?

Login with username, password and session length

[Steven Koontz]

Hello

I have been modding some JReviews classes for integration into my new RocketTheme Kirigami template, and when I changed the button class on the advanced search module from "jrButton" to "button" it breaks the proximity search. It seems like it just skips the DB query and goes directly to "no results".

I also changed the button class on the standard advanced search module (without geomaps functions) and that works fine.

Here is a URL: http://miraargentina.com/test-page.

Try this for your searches: Category: Alojamiento; Location: Bariloche, Río Negro, Argentina; Radius: 5km.

You can see that the results are empty. On the homepage I have the same module with jrButton and if you try it you will see that it works fine. Also on the homepage I have a standard advanced search module where jrButton has been replaced by button which if you try it you will also see that it works fine.

Is there any way to avoid this? And will I also run in to problems when changing the classes of the other JReviews submit buttons?

[Alejandro]

I don't see why this is a problem. I am pretty sure none of the jQuery code looks for elements with the jrButton class. Could it be instead the RokBooster plugin that is messing things up or JCS if you use that one? You could also add a new class instead of removing the old one and concatenate them in CSS to override it.

.jrButton.button {}

In JReviews 2.4 we defined a "standard" for css classes that are used for javascript calls and those that are used for styling purposes only. js classes are hyphenated (jr-some-class), while style classes are camelized (jrSomeClass). Then you know what you can change without breaking anything.

[Steven Koontz]

I don't see why this is a problem. I am pretty sure none of the jQuery code looks for elements with the jrButton class. Could it be instead the RokBooster plugin that is messing things up or JCS if you use that one?

I don't get it, either. I do not use RokBooster (because it s*cks) and I turn off JCH Optimize for testing before writing a post. It's just weird that it works for advanced_search but not for advanced_search_maps.

In JReviews 2.4 we defined a "standard" for css classes that are used for javascript calls and those that are used for styling purposes only. js classes are hyphenated (jr-some-class), while style classes are camelized (jrSomeClass). Then you know what you can change without breaking anything.

This is great news. There are lots of theme mods I am holding off on and this will be one more. Thanks for the response.

While we're on the topic of proximity search, there have been lots of feature requests for proximity results in the related listings widgets. Now that you have the v3 API of Google Maps implemented and working well with proximity searches, would it really be that hard to add this feature to the related listings widgets? I have my fingers crossed for this functionality after the big media version is finally over with.

[Alejandro]

A proximity widget wouldn't be too difficult to implement, it's just a matter of finding the time to do it. I already posted the related query code for this in another post

http://www.reviewsforjoomla.com/forum/index.php?topic=17858.msg74898#msg74898